liurenjie1024 commented on code in PR #951:
URL: https://github.com/apache/iceberg-rust/pull/951#discussion_r2021130579
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -1593,4 +1693,148 @@ message schema {
(file_io, schema, table_location, tmp_dir)
}
+
+ #[test]
+ fn test_build_deletes_row_selection() {
Review Comment:
This test is not enough, should we consider using [property
test](https://github.com/BurntSushi/quickcheck) to generate random data to
verify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
