wgtmac commented on code in PR #53:
URL: https://github.com/apache/iceberg-cpp/pull/53#discussion_r2020353401
##########
src/iceberg/arrow_c_data.h:
##########
@@ -66,6 +71,47 @@ struct ArrowArray {
void* private_data;
};
-} // extern "C"
-
#endif // ARROW_C_DATA_INTERFACE
+
+#ifndef ARROW_C_STREAM_INTERFACE
+# define ARROW_C_STREAM_INTERFACE
+
+struct ArrowArrayStream {
Review Comment:
I have removed ArrowArrayStream. I think internally we can just include
`nanoarrow.h` so we don't have to add ArrowArrayStream and confuse the
downstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
