Fokko commented on code in PR #1146:
URL: https://github.com/apache/iceberg-rust/pull/1146#discussion_r2020238880
##########
crates/iceberg/src/transform/temporal.rs:
##########
@@ -337,12 +337,12 @@ pub struct Hour;
impl Hour {
#[inline]
fn hour_timestamp_micro(v: i64) -> i32 {
- (v / MICROSECONDS_PER_HOUR) as i32
+ (v as f64 / MICROSECONDS_PER_HOUR).floor() as i32
Review Comment:
Love it, thanks for the suggestion! 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
