zeroshade commented on code in PR #356:
URL: https://github.com/apache/iceberg-go/pull/356#discussion_r2019217138
##########
table/snapshot_producers.go:
##########
@@ -89,9 +97,147 @@ func (fa *fastAppendFiles) existingManifests()
([]iceberg.ManifestFile, error) {
}
func (fa *fastAppendFiles) deletedEntries() ([]iceberg.ManifestEntry, error) {
+ // for fast appends, there are no deleted entries
return nil, nil
}
+type overwriteFiles struct {
+ base *snapshotProducer
+}
+
+func newOverwriteFilesProducer(op Operation, txn *Transaction, fs
iceio.WriteFileIO, commitUUID *uuid.UUID, snapshotProps iceberg.Properties)
*snapshotProducer {
+ prod := createSnapshotProducer(op, txn, fs, commitUUID, snapshotProps)
Review Comment:
at the moment yes. But i figure we can re-use this for `replace` operations
eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
