amogh-jahagirdar commented on code in PR #12657:
URL: https://github.com/apache/iceberg/pull/12657#discussion_r2018901995
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkBucketFunction.java:
##########
@@ -74,10 +74,14 @@ public void testSpecValues() {
.as("Spec example: hash(2017-11-16T22:31:08) = -2047944441")
.isEqualTo(-2047944441);
- assertThat(new BucketFunction.BucketString().hash("iceberg"))
+ assertThat(new
BucketFunction.BucketString().hash("iceberg".getBytes(StandardCharsets.UTF_8)))
Review Comment:
Nit: Same as above, we could just leave this assertion the same as earlier
just to keep the diff smaller.
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkBucketFunction.java:
##########
@@ -82,7 +82,12 @@ public void testSpecValues() {
Assert.assertEquals(
"Spec example: hash(\"iceberg\") = 1210000089",
1210000089,
- new BucketFunction.BucketString().hash("iceberg"));
+ new
BucketFunction.BucketString().hash("iceberg".getBytes(StandardCharsets.UTF_8)));
Review Comment:
Nit: We could just leave this the same as before just to keep the diff
smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
