Re: [PR] Make `schema` and `partition_spec` optional for TableMetadataV1 [iceberg-rust]

[via GitHub]

phillipleblanc commented on code in PR #1087:
URL: https://github.com/apache/iceberg-rust/pull/1087#discussion_r2018836705


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -966,10 +970,15 @@ pub(super) mod _serde {
 
             let partition_specs = match value.partition_specs {
                 Some(partition_specs) => partition_specs,
-                None => vec![PartitionSpec::builder(current_schema.clone())
-                    .with_spec_id(DEFAULT_PARTITION_SPEC_ID)
-                    
.add_unbound_fields(value.partition_spec.into_iter().map(|f| f.into_unbound()))?
-                    .build()?],
+                None => match value.partition_spec {
+                    Some(partition_spec) => 
vec![PartitionSpec::builder(current_schema.clone())

Review Comment:
   I've pushed a change that should do this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org