danielcweeks commented on code in PR #12595:
URL: https://github.com/apache/iceberg/pull/12595#discussion_r2017706222


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -135,6 +135,10 @@ public HTTPClient withAuthSession(AuthSession session) {
     return new HTTPClient(this, session);
   }
 
+  public Map<String, String> getBaseHeaders() {

Review Comment:
   Late comments: we don't use `get` prefix for accessors. Please change to 
`baseHeaders()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to