rdblue commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2012807189


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -324,9 +348,8 @@ private Long calculateAddedRows(List<ManifestFile> 
manifests) {
   protected abstract Map<String, String> summary();
 
   /** Returns the snapshot summary from the implementation and updates totals. 
*/
-  private Map<String, String> summary(TableMetadata previous) {
-    Map<String, String> summary = summary();
-
+  private Map<String, String> summaryWithTotals(

Review Comment:
   Rolled this back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to