nastra commented on code in PR #12582: URL: https://github.com/apache/iceberg/pull/12582#discussion_r2012571306
########## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthManager.java: ########## @@ -63,6 +63,7 @@ public RESTSigV4AuthSession catalogSession( @Override public RESTSigV4AuthSession contextualSession( SessionCatalog.SessionContext context, AuthSession parent) { + Preconditions.checkState(parent instanceof RESTSigV4AuthSession, "parent session is not SigV4"); Review Comment: ```suggestion Preconditions.checkState(parent instanceof RESTSigV4AuthSession, "Parent session is not SigV4: %s", parent); ``` same for the other check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org