amogh-jahagirdar commented on issue #12642: URL: https://github.com/apache/iceberg/issues/12642#issuecomment-2751890851
I remember seeing this in the implementation and thinking the same thing, but it never surfaced as an issue for us. Probably because with continuous maintenance N was small so even if it was N^2 it didn't really end up making too much of a difference. I think it makes total sense though to fix this (e.g. it's totally possible that snapshots accumulated and for whatever reason expiration couldn't run for a while, and I agree with the proposed fix we should just pass in the whole set of snapshots to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
