wgtmac commented on code in PR #47: URL: https://github.com/apache/iceberg-cpp/pull/47#discussion_r2011297178
########## src/iceberg/type_fwd.h: ########## @@ -81,4 +81,36 @@ class TimestampTzType; class Type; class UuidType; +/// \brief Error types for iceberg. +/// TODO: add more and sort them based on some rules. +enum class ErrorKind { Review Comment: Yes, I was also thinking of adding a detail error message like: ``` struct Error { ErrorKind kind; std::string message; }; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org