nastra commented on code in PR #12596:
URL: https://github.com/apache/iceberg/pull/12596#discussion_r2010345722
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
##########
@@ -311,6 +317,22 @@ public void testConflictingColumns() {
sql("SELECT _spec_id, _partition, _renamed_spec_id FROM %s",
TABLE_NAME));
}
+ @TestTemplate
+ public void testRowLineageColumnsResolvedInV3OrHigher() {
+ if (formatVersion >= 3) {
+ assertEquals(
+ "Rows must match",
+ ImmutableList.of(),
+ sql("SELECT _row_id, _last_updated_sequence_number, id FROM %s",
TABLE_NAME));
+ } else {
+ // Should fail to resolve row lineage metadata columns in V1/V2 tables
+ assertThatThrownBy(() -> sql("SELECT _row_id FROM %s", TABLE_NAME))
+ .isInstanceOf(AnalysisException.class);
Review Comment:
minor: this and the check below should have a `hasMessage()` check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
