nastra commented on code in PR #12627:
URL: https://github.com/apache/iceberg/pull/12627#discussion_r2009657858
##########
core/src/test/java/org/apache/iceberg/TestCommitReporting.java:
##########
@@ -196,14 +196,9 @@ public void addAndDeleteManifests() throws IOException {
CommitReport report = reporter.lastCommitReport();
assertThat(report).isNotNull();
- assertThat(report.operation()).isEqualTo("append");
- assertThat(report.snapshotId()).isEqualTo(2L);
- assertThat(report.sequenceNumber()).isEqualTo(2L);
+ assertThat(report.operation()).isEqualTo("replace");
+ assertThat(report.snapshotId()).isEqualTo(3L);
+ assertThat(report.sequenceNumber()).isEqualTo(3L);
assertThat(report.tableName()).isEqualTo(tableName);
-
- CommitMetricsResult metrics = report.commitMetrics();
Review Comment:
I'd probably change this to
```
CommitMetricsResult metrics = report.commitMetrics();
assertThat(metrics.totalDataFiles().value()).isEqualTo(2L);
assertThat(metrics.totalRecords().value()).isEqualTo(2L);
assertThat(metrics.totalFilesSizeInBytes().value()).isEqualTo(20L);
```
so that we at least check that some metrics were recorded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
