nastra commented on code in PR #12624:
URL: https://github.com/apache/iceberg/pull/12624#discussion_r2009605645
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -92,6 +92,20 @@
<property name="format"
value="^\s*import\s+static\s+(?!\Qorg.assertj.core.api.Assertions.\E).*\.assertThatThrownBy;"/>
<property name="message" value="assertThatThrownBy() should be
statically imported from org.assertj.core.api.Assertions"/>
</module>
+ <module name="RegexpMultiline">
+ <property name="id" value="AssertThatThrownByWithMessageCheck"/>
+ <property name="fileExtensions" value="java"/>
+ <property name="matchAcrossLines" value="true"/>
+ <property name="format"
value="assertThatThrownBy\((?:(?!\.hasMessage\w*\().)*?isInstanceOf\((?:(?!\.hasMessage\w*\().)*?;"/>
+ <property name="message" value="assertThatThrownBy must include a
message check like .hasMessageContaining(...)"/>
Review Comment:
```suggestion
<property name="message" value="assertThatThrownBy must include a
message check like .hasMessage(...)"/>
```
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -92,6 +92,20 @@
<property name="format"
value="^\s*import\s+static\s+(?!\Qorg.assertj.core.api.Assertions.\E).*\.assertThatThrownBy;"/>
<property name="message" value="assertThatThrownBy() should be
statically imported from org.assertj.core.api.Assertions"/>
</module>
+ <module name="RegexpMultiline">
+ <property name="id" value="AssertThatThrownByWithMessageCheck"/>
+ <property name="fileExtensions" value="java"/>
+ <property name="matchAcrossLines" value="true"/>
+ <property name="format"
value="assertThatThrownBy\((?:(?!\.hasMessage\w*\().)*?isInstanceOf\((?:(?!\.hasMessage\w*\().)*?;"/>
+ <property name="message" value="assertThatThrownBy must include a
message check like .hasMessageContaining(...)"/>
+ </module>
+ <module name="RegexpMultiline">
+ <property name="id" value="AssertThatExceptionOfTypeWithMessageCheck"/>
+ <property name="fileExtensions" value="java"/>
+ <property name="matchAcrossLines" value="true"/>
+ <property name="format"
value="assertThatExceptionOfType\((?:(?!\.withMessage\w*\().)*?isThrownBy\((?:(?!\.withMessage\w*\().)*?;"/>
+ <property name="message" value="assertThatExceptionOfType must include
a message check like .withMessageContaining(...)"/>
Review Comment:
```suggestion
<property name="message" value="assertThatExceptionOfType must
include a message check like .withMessage(...)"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
