jdockerty commented on code in PR #1116: URL: https://github.com/apache/iceberg-rust/pull/1116#discussion_r2007376988
########## crates/iceberg/src/spec/mapped_fields.rs: ########## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Iceberg mapped fields. + +use std::collections::HashMap; + +use serde::{Deserialize, Serialize}; + +use crate::spec::MappedField; + +/// Utility mapping which contains field names to IDs and +/// field IDs to the underlying [`MappedField`]. +#[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)] +pub struct MappedFields { + fields: Vec<MappedField>, + name_to_id: HashMap<String, i32>, + id_to_field: HashMap<i32, MappedField>, +} + +impl MappedFields { + /// Create a new [`MappedFields`]. + pub fn new(fields: Vec<MappedField>) -> Self { + let mut name_to_id = HashMap::new(); + let mut id_to_field = HashMap::new(); + + for field in &fields { + if let Some(id) = field.field_id() { + id_to_field.insert(id, field.clone()); Review Comment: Makes sense to me :+1: Does this matter that it differs from the Java impl here? I modelled this based on the [Java impl](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/core/src/main/java/org/apache/iceberg/mapping/MappedFields.java#L61) and it doesn't look like they have duplicate checks there, perhaps I'm missing something very obvious though from not doing much Java :laughing: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
