emkornfield opened a new pull request, #12598: URL: https://github.com/apache/iceberg/pull/12598
I am not sure if this is the best place to put the details (open to suggestions on creating another section elsewhere or if there are thoughts on a better section to add the sentences to). The logic documented is reverse engineered from [TableMetadataParser.Codec](http://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L68). Which is a little bit odd, since in theory it allows for file names like `v0gz.metadata.json.foo` to correctly return as GZIP. I assume the file name needs to end in `.metadata.json` based on [FileFormat.fromFileName](http://github.com/apache/iceberg/blob/e47e99a0dd3a500134633df640522c8c8fb56a2b/api/src/main/java/org/apache/iceberg/FileFormat.java#L60) which I assume would end up crashing if a null value was returned and from the specification mandating these file names for commits (even though this isn't strictly necessary for catalog based commits). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
