adutra commented on code in PR #12582: URL: https://github.com/apache/iceberg/pull/12582#discussion_r2005526729
########## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthManager.java: ########## @@ -61,20 +61,29 @@ public RESTSigV4AuthSession catalogSession( } @Override - public AuthSession contextualSession(SessionCatalog.SessionContext context, AuthSession parent) { + public RESTSigV4AuthSession contextualSession( + SessionCatalog.SessionContext context, AuthSession parent) { AwsProperties contextProperties = - new AwsProperties(RESTUtil.merge(catalogProperties, context.properties())); + new AwsProperties( + RESTUtil.merge( + catalogProperties, + // Use both context properties and credentials to create the AwsProperties instance Review Comment: Uncovered this while adding more tests: the context credentials were being ignored, only the context properties were being used – but some information might be present in the credentials map, such as AWS access key ids + secrets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org