mxm commented on code in PR #12527:
URL: https://github.com/apache/iceberg/pull/12527#discussion_r2005058648
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java:
##########
@@ -46,13 +45,12 @@ class IcebergStreamWriter<T> extends
AbstractStreamOperator<FlinkWriteResult>
IcebergStreamWriter(String fullTableName, TaskWriterFactory<T>
taskWriterFactory) {
this.fullTableName = fullTableName;
this.taskWriterFactory = taskWriterFactory;
- setChainingStrategy(ChainingStrategy.ALWAYS);
Review Comment:
This isn't supported anymore. Forced chaining can only be controlled by the
Flink runtime. The operator will still be chained though, unless chaining is
globally disabled.
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/StatisticsOrRecordTypeInformation.java:
##########
@@ -79,11 +78,6 @@ public TypeSerializer<StatisticsOrRecord>
createSerializer(SerializerConfig conf
return new StatisticsOrRecordSerializer(globalStatisticsSerializer,
recordSerializer);
}
- @Override
- public TypeSerializer<StatisticsOrRecord> createSerializer(ExecutionConfig
config) {
Review Comment:
The interface doesn't have this method anymore. Note that there is another
`createSerializer` method just above (line 76).
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingReaderOperator.java:
##########
@@ -275,7 +274,6 @@ private OneInputStreamOperatorTestHarness<FlinkInputSplit,
RowData> createReader
StreamingReaderOperator.factory(inputFormat);
OneInputStreamOperatorTestHarness<FlinkInputSplit, RowData> harness =
new OneInputStreamOperatorTestHarness<>(factory, 1, 1, 0);
-
harness.getStreamConfig().setTimeCharacteristic(TimeCharacteristic.ProcessingTime);
Review Comment:
That's no longer required. The test harness changed. The change is test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
