liurenjie1024 commented on code in PR #1114: URL: https://github.com/apache/iceberg-rust/pull/1114#discussion_r2004655102
########## Cargo.toml: ########## @@ -35,6 +35,7 @@ homepage = "https://rust.iceberg.apache.org/"; repository = "https://github.com/apache/iceberg-rust"; license = "Apache-2.0" +# check the MSRV policy in README.md before changing this Review Comment: ```suggestion # Check the MSRV policy in README.md before changing this ``` ########## CONTRIBUTING.md: ########## @@ -26,12 +26,16 @@ First, thank you for contributing to Iceberg Rust! The goal of this document is - [Git Branches](#git-branches) - [GitHub Pull Requests](#github-pull-requests) - [Title](#title) - - [Reviews & Approvals](#reviews--approvals) + - [Reviews \& Approvals](#reviews--approvals) - [Merge Style](#merge-style) - - [CI](#ci) + - [CI](#ci) - [Setup](#setup) - [Using a dev container environment](#using-a-dev-container-environment) - [Bring your own toolbox](#bring-your-own-toolbox) + - [Install rust](#install-rust) Review Comment: Should we consider using [TOC] directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
