rdblue commented on code in PR #12533:
URL: https://github.com/apache/iceberg/pull/12533#discussion_r2002166829
##########
format/spec.md:
##########
@@ -1395,8 +1395,8 @@ Types are serialized according to this table:
|**`list`**|`JSON object: {`<br /> `"type": "list",`<br
/> `"element-id": <id int>,`<br /> `"element-required":
<bool>`<br /> `"element": <type JSON>`<br />`}`|`{`<br
/> `"type": "list",`<br /> `"element-id": 3,`<br
/> `"element-required": true,`<br /> `"element":
"string"`<br />`}`|
|**`map`**|`JSON object: {`<br /> `"type": "map",`<br
/> `"key-id": <key id int>,`<br /> `"key": <type
JSON>,`<br /> `"value-id": <val id int>,`<br
/> `"value-required": <bool>`<br /> `"value": <type
JSON>`<br />`}`|`{`<br /> `"type": "map",`<br
/> `"key-id": 4,`<br /> `"key": "string",`<br
/> `"value-id": 5,`<br /> `"value-required": false,`<br
/> `"value": "double"`<br />`}`|
| **`variant`**| `JSON string: "variant"`|`"variant"`|
-| **`geometry(C)`** | `JSON object: {`<br /> `"type":
"geometry",`<br /> `"crs": <C>`<br />`}` | `{`<br
/> `"type": "geometry",`<br /> `"crs": "srid:4326"`<br
/>`}` |
-| **`geography(C, A)`** | `JSON object: {`<br /> `"type":
"geography",`<br /> `"crs": <C>,`<br /> `"algorithm":
<A>`<br />}` | `{`<br /> `"type": "geography",`<br
/> `"crs": "srid:4326",`<br /> `"algorithm": "spherical"`
<br /> `}` |
+| **`geometry(C)`** |`JSON string: "geometry(<C>)"`|`"geometry(srid:4326)"`|
+| **`geography(C, A)`** |`JSON string:
"geography(<C>,<E>)"`|`"geography(srid:4326,spherical)"`|
Review Comment:
I agree with adding a couple examples without type params, but I think this
is minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
