smaheshwar-pltr commented on code in PR #12257:
URL: https://github.com/apache/iceberg/pull/12257#discussion_r1997678815
##########
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java:
##########
@@ -51,7 +53,12 @@ public RewriteDataFilesCommitManager(Table table, long
startingSnapshotId) {
public RewriteDataFilesCommitManager(
Table table, long startingSnapshotId, boolean useStartingSequenceNumber)
{
- this(table, startingSnapshotId, useStartingSequenceNumber,
ImmutableMap.of());
+ this(
+ table,
+ startingSnapshotId,
+ useStartingSequenceNumber,
+ ImmutableMap.of(),
+ SnapshotRef.MAIN_BRANCH);
Review Comment:
Minor: these constructors read slightly off to me - the default branch being
`main` is encoded in *two* constructors, and the one below doesn't chain.
My opinion: maybe keep this constructor as it was before, and replace the
body of *the one below* with
```java
this(table, startingSnapshotId, useStartingSequenceNumber,
snapshotProperties, SnapshotRef.MAIN_BRANCH);
```
to keep the constructor-chaining flow with each setting one default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
