rcjverhoef opened a new pull request, #12540: URL: https://github.com/apache/iceberg/pull/12540
See https://github.com/apache/iceberg/issues/12539 I am adding the `io` to the `closeableGroup` with this PR. Any FileIO that is opened should ideally be closed and not left to linger for the garbage collector to pick up. The `io` variable is passed to `JdbcViewOperations` and `JdbcTableOperations` outside this class, but those already get the `connections` variable passed in as well that gets closed. This makes me not super worried about a usages outside this class (this might be worth revisting?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
