connortsui20 commented on issue #1038: URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2719630195
I'll circle back to one of the ideas I brought up: using `thiserror` or `snafu` to help build better error handling. Using either would provide strictly more functionality and would not lose any of the expression (that I can see). And as a side note, I think that the current methodology of constructing an empty `Error` and adding static `context` is not very robust. Doing a quick search through this entire repository, I don't really see such a large number of unique situations that would justify needing to dynamically specify these context fields. It makes a lot more sense to define errors over enum variants, where each variant can decide what fields it needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
