helmiazizm commented on code in PR #1788:
URL: https://github.com/apache/iceberg-python/pull/1788#discussion_r1992533665
##########
pyiceberg/io/fsspec.py:
##########
@@ -124,6 +128,22 @@ def _file(_: Properties) -> LocalFileSystem:
return LocalFileSystem(auto_mkdir=True)
+def _oss(properties: Properties) -> AbstractFileSystem:
+ from s3fs import S3FileSystem
+
+ client_kwargs = {
+ "endpoint_url": properties.get(OSS_ENDPOINT),
+ "aws_access_key_id": properties.get(OSS_ACCESS_KEY_ID),
+ "aws_secret_access_key": properties.get(OSS_ACCESS_KEY_SECRET),
+ "aws_session_token": properties.get(OSS_SESSION_TOKEN),
+ }
+ config_kwargs = {"s3": {"addressing_style": "virtual"},
"signature_version": "v4"}
Review Comment:
Since the init function for OSS is already separated from S3, and users
aren't able to interact with OSS without virtual addressing set to true anyway,
I think it makes more sense to just set it to true by default to make it
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
