danielcweeks commented on code in PR #12476:
URL: https://github.com/apache/iceberg/pull/12476#discussion_r1992228059
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -192,13 +191,11 @@ public List<DeleteFile> deletes() {
@Override
public CloseableIterable<StructLike> rows() {
try (CloseableIterable<ManifestFile> manifests =
- Avro.read(io.newInputFile(manifestListLocation))
- .rename("manifest_file", GenericManifestFile.class.getName())
- .rename("partitions",
GenericPartitionFieldSummary.class.getName())
- .rename("r508", GenericPartitionFieldSummary.class.getName())
+ InternalData.read(FileFormat.AVRO,
io.newInputFile(manifestListLocation))
+ .setRootType(GenericManifestFile.class)
+ .setCustomType(508, GenericPartitionFieldSummary.class)
.project(ManifestFile.schema())
.classLoader(GenericManifestFile.class.getClassLoader())
- .reuseContainers(false)
Review Comment:
Yes, the new interface just has `reuseContainers()` to enable reuse, but no
flag to change the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
