Re: [PR] feat(core): expose remove_snapshots at Transaction API [iceberg-rust]

[via GitHub]

ZENOTME commented on PR #884:
URL: https://github.com/apache/iceberg-rust/pull/884#issuecomment-2716708182

   > > This is a hard limit in the server implementation. I am not sure about 
the reason for this design, as I am not familiar enough with the specification 
of iceberg.
   > 
   > +1, I also encountered this problem. What is confusing is that the 
semantics of the rest api is inconsistent with the server implementation.
   > 
   > 
https://github.com/apache/iceberg/blob/3dba6afb789a420373e44ac29ecdef866bd7ebee/core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java#L557
   > 
   > 
https://github.com/apache/iceberg/blob/6e8718113c08aebf76d8e79a9e2534c89c73407a/open-api/rest-catalog-open-api.yaml#L2823
   > 
   > <img alt="image" width="1444" 
src="https://private-user-images.githubusercontent.com/15023748/421739563-e0438be0-359c-4673-a1c0-ed16030d2049.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDE3NjE5MTMsIm5iZiI6MTc0MTc2MTYxMywicGF0aCI6Ii8xNTAyMzc0OC80MjE3Mzk1NjMtZTA0MzhiZTAtMzU5Yy00NjczLWExYzAtZWQxNjAzMGQyMDQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzEyVDA2NDAxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE5N2M0ZmZlNzliNjZiYTBhMmIyNmIwZjg3NDIwMjE1OGUxODA3ZTM2Nzk0Njg0MjJiOTZlZDM3OTYyN2MyMTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.v07YHpbNsV6wBBWJ6iJ1I07JJDDGXEvcsB3beht02v0";>
   
   Looks like this hard limit will affect the remove_snapshots implementation. 
e.g. we must separate multiple remove snapshot id into multiple remove snapshot 
requests rather than ids in one remove snapshot request. cc @Fokko 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org