ZENOTME commented on issue #270: URL: https://github.com/apache/iceberg-python/issues/270#issuecomment-2713768454
Hi, recently I'm trying to investigate support rewrite manifest in iceberg-rust. And the design of iceberg-rust is following iceberg-python, basically, but for now, rewrite manifest is not supported in iceberg-python so I have to refer to the implementation of iceberg-java. In iceberg-java, the rewrite manifest is based on SnapshotProducer and I find that the design of SnapshotProducer between iceberg-java and python is a little different. In iceberg-python, SnapshotProducer is a more "fine grained" abstract, e.g. it provides the summary implementation, `add_data_file` interface. But in iceberg-java, the SnapshotProducer needs the child type to implement the summary. Which means that we can't directly implement rewrite manifest based on SnapshotProducer. In iceberg-python design, I can think of two ways to implement rewrite manifest: 1. Don't base on SnapshotProducer 2. Change the SnapshotProducer design to similar to java, and implement the rewrite manifest based on SnapshotProducer I'm interested in which design iceberg-python will choice and as a refer for iceberg-rust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
