Fokko commented on PR #1783:
URL: https://github.com/apache/iceberg-python/pull/1783#issuecomment-2715461531

   I like the solution!
   
   > changing the visitor to an iterative approach seems like a sound solution. 
are there any reasons we dont want to do this?
   
   My only concern is performance. We probably want to check what the impact 
is, since we bind to schemas all over the codebase. It would be good to see if 
we can get some numbers on the impact on the performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to