zratkai commented on code in PR #12461:
URL: https://github.com/apache/iceberg/pull/12461#discussion_r1989173702
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -230,12 +220,12 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
.collect(Collectors.toSet());
}
- Map<String, String> summary =
- Optional.ofNullable(metadata.currentSnapshot())
- .map(Snapshot::summary)
- .orElseGet(ImmutableMap::of);
- setHmsTableParameters(
- newMetadataLocation, tbl, metadata, removedProps, hiveEngineEnabled,
summary);
+ icebergTableConverter.setHmsTableParameters(newMetadataLocation, tbl,
+ metadata, removedProps, hiveEngineEnabled);
+ if (currentMetadataLocation() != null &&
!currentMetadataLocation().isEmpty()) {
Review Comment:
Yes, the reason is it is not needed where this PR originates from. So I can
reuse the table property setting part in my PR, but this part won't be a
common, this is why I have it here, but not in the other PR:
https://github.com/apache/hive/pull/5628#discussion_r1979230748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
