Fokko commented on code in PR #1066:
URL: https://github.com/apache/iceberg-rust/pull/1066#discussion_r1986962950


##########
crates/iceberg/src/writer/mod.rs:
##########
@@ -26,23 +26,58 @@
 //! 2. IcebergWriter: Focus on the logical format of iceberg table. It will 
write the data using the FileWriter finally.
 //!
 //! # Simple example for data file writer:

Review Comment:
   Should we put this example under the `examples` crate? Otherwise it might go 
out of sync again soon
   
   https://github.com/apache/iceberg-rust/tree/main/crates/examples/src



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to