liurenjie1024 commented on code in PR #1010:
URL: https://github.com/apache/iceberg-rust/pull/1010#discussion_r1986608581
##########
crates/catalog/rest/src/client.rs:
##########
@@ -214,7 +214,9 @@ impl HttpClient {
#[inline]
pub fn request<U: IntoUrl>(&self, method: Method, url: U) ->
RequestBuilder {
- self.client.request(method, url)
+ self.client
Review Comment:
There are several places to send http request, not only `request` method,
but also `query`, `do_query` method below. I think a better approach would be
to use `ClientBuilder` to config `default_headers`? See
https://docs.rs/reqwest/latest/reqwest/struct.ClientBuilder.html#method.default_headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
