liurenjie1024 commented on issue #1004: URL: https://github.com/apache/iceberg-rust/issues/1004#issuecomment-2702526583
> [@liurenjie1024](https://github.com/liurenjie1024) I think the current problem with this is that `ArrowFileReader` (reader) returns `ParquetMetadata` and `AsyncFileWriter` (writer) returns the thrift definition. The solution I was thinking of is creating a conversion from thrift -> ParquetMetadata, but this seems like an unnecessary step. I think keeping both functions so that the parquet writer can convert to datafile given any of the two metadatas without an unnecessary conversion step in between seems to be fine. I think we should always return the in memory representation, rather the thrift one. Is there any case where returning the thrift one is more useful then the in memory one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
