rdblue commented on PR #12455: URL: https://github.com/apache/iceberg/pull/12455#issuecomment-2699284354
> The only thing I note is that we're changing the terminology a little (option -> optional). While I agree with the using `optional` as it is less confusing, we're slightly inconsistent. The distinction I was going for was between an optional field (may be null) and an option schema (a union of null and another type). I know it's a bit weird, but I didn't want to rename all of the uses of the latter meaning because we have `isOptionSchema`, `toOption`, and `fromOption` methods. I think this is the cleanest option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
