aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1979981102
##########
core/src/main/java/org/apache/iceberg/avro/AvroCustomOrderSchemaVisitor.java:
##########
@@ -35,20 +38,29 @@ public static <T, F> T visit(Schema schema,
AvroCustomOrderSchemaVisitor<T, F> v
Preconditions.checkState(
!visitor.recordLevels.contains(name), "Cannot process recursive
Avro record %s", name);
- visitor.recordLevels.push(name);
Review Comment:
@rdblue I commented above. As I understand that we are trying to error out
for the recursive Avro schema. But since we know Variant record will not have
records inside, that's why I didn't place that inside visitor.recordLevels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
