singhpk234 commented on code in PR #12451: URL: https://github.com/apache/iceberg/pull/12451#discussion_r1980150585
########## api/src/main/java/org/apache/iceberg/actions/ComputePartitionStats.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.PartitionStatisticsFile; + +/** An action that computes and writes the partition statistics of an Iceberg table. */ +public interface ComputePartitionStats + extends Action<ComputePartitionStats, ComputePartitionStats.Result> { + /** + * Choose the table branch to compute stats, if not specified, uses the default branch. + * + * @param branch branch name of the table for which stats need to be computed + * @return this for method chaining + */ + ComputePartitionStats branch(String branch); Review Comment: [Not a blocker] just linking prev discussions: https://github.com/apache/iceberg/pull/10288#discussion_r1619236342 as similar thing came up and we endup going with just snapshotId for ComputeTableStats. Also a point to consider, table level stats already has just snapshotId, it would be nice to have parity or may be support both ? your thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
