Fokko commented on code in PR #1720:
URL: https://github.com/apache/iceberg-python/pull/1720#discussion_r1979101949
##########
pyiceberg/table/__init__.py:
##########
@@ -1874,7 +1875,7 @@ class WriteTask:
def generate_data_file_filename(self, extension: str) -> str:
Review Comment:
How about:
```suggestion
def generate_data_file_filename(self, extension: str, task_id:
Optional[int]) -> str:
```
To only include the task ID for distributed engines?
##########
pyiceberg/table/__init__.py:
##########
@@ -1874,7 +1875,7 @@ class WriteTask:
def generate_data_file_filename(self, extension: str) -> str:
Review Comment:
How about:
```suggestion
def generate_data_file_filename(self, extension: str, task_id:
Optional[int] = None) -> str:
```
To only include the task ID for distributed engines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
