nastra commented on code in PR #12159:
URL: https://github.com/apache/iceberg/pull/12159#discussion_r1977420024


##########
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##########
@@ -244,6 +244,33 @@ public void viewExistsViaHEADRequest() {
             any());
   }
 
+  @Test
+  public void renameViewNamespaceHavingCatalogName() {
+    TableIdentifier from = TableIdentifier.of("ns", "table");
+    TableIdentifier to = TableIdentifier.of("ns", "renamedTable");
+    TableIdentifier toWithCatalogName = TableIdentifier.of(catalog().name(), 
"ns", "renamedTable");
+
+    if (requiresNamespaceCreate()) {
+      catalog().createNamespace(from.namespace());
+    }
+    assertThat(catalog().viewExists(from)).as("View should not 
exist").isFalse();

Review Comment:
   nit: please add a newline right before this line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to