anuragmantri commented on issue #12236: URL: https://github.com/apache/iceberg/issues/12236#issuecomment-2692332346
> what does "we dont run AWS integration tests at all" mean? AWS integration tests require some keys as ENV vars to successfully run. So today our CI does not run any AWS integration tests. If we move the current docker tests to integration, they will be missed. An option I proposed is to create a new suite called `dockerIntegrationTests` for AWS so we can run these. See [here](https://github.com/apache/iceberg/pull/12274#issuecomment-2664067160) and [here](https://github.com/apache/iceberg/pull/12274#issuecomment-2664824667). I'm open to better ideas though. > I thought the idea was to move these to integrationTest so that ./gradlew build only runs unit tests. And we can add additional integration tests run command. Yes, this is indeed the idea. We already have `gradlew integrationTest` some modules already have tests that run on `gradle check` in the CI. It's just the AWS ones don't run today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
