connortsui20 commented on PR #965: URL: https://github.com/apache/iceberg-rust/pull/965#issuecomment-2692263199
> > @Xuanwo could you take a look at the [latest commit](https://github.com/apache/iceberg-rust/pull/965/commits/0f72f01a6963cb97475a2dcd4776aba794ea0932) and see if it makes sense? > > Hi, I'm still not in favor of the `handler` style. The stack size of my brain is not sufficient to handle the extra handler (sorry for that). Maybe we could consider the following? > > ```rust > let resp: Response = client.query_catalog(request).await?; > if response.status() == StatusCode::OK { > deserialize_catalog_response::<CatalogConfig>(response).await > } else { > Err(deserialize_unexpected_catalog_error(response).await) > } > ``` Okay, I'll make that change and then we can reevaluate if it makes more sense to delay any serialization errors. You're probably right by the way, I guess I just think about this weirdly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
