abstractdog commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r1975825857
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -197,7 +198,7 @@ protected String targetBranch() {
}
protected ExecutorService workerPool() {
- return this.workerPool;
+ return
Optional.ofNullable(workerPool).orElseGet(ThreadPools::getWorkerPool);
Review Comment:
yeah, I think it's a cool one-liner, assuming that repeatedly calling
ThreadPools::getWorkerPool is not expensive, which is true because it just
returns the pool from the 2nd call:
```
public static ExecutorService getWorkerPool() {
return WORKER_POOL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
