adutra commented on code in PR #12415:
URL: https://github.com/apache/iceberg/pull/12415#discussion_r1973976074


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -258,7 +258,9 @@ public void initialize(String name, Map<String, String> 
unresolved) {
         config = fetchConfig(initClient, authHeaders, props);
       } else {
         authResponse = null;
-        config = fetchConfig(initClient, initHeaders, props);
+        Map<String, String> authHeaders =

Review Comment:
   I think I see the problem.
   
   But I would rather change line 251.
   
   The original line was:
   
   ```java
   Map<String, String> initHeaders =
             RESTUtil.merge(configHeaders(props), 
OAuth2Util.authHeaders(initToken));
   ```
   
   For some reason, it became:
   
   ```java
   Map<String, String> initHeaders = configHeaders(props);
   ```
   
   I think this was a mistake. Wdyt?
   
   **UPDATE**
   see my next comment, I do not think there is anything wrong here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to