kevinjqliu commented on code in PR #311:
URL: https://github.com/apache/iceberg-go/pull/311#discussion_r1970105364
##########
table/scanner_test.go:
##########
@@ -458,6 +458,23 @@ func (s *ScannerSuite) TestPartitionedTables() {
}
}
+func (s *ScannerSuite) TestNestedColumns() {
+ mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
+ defer mem.AssertSize(s.T(), 0)
+
+ ident := catalog.ToIdentifier("default", "test_all_types")
Review Comment:
is this the nested col?
https://github.com/apache/iceberg-go/blob/b1b432e7164b66a61a00b2a6ed312596661275b1/dev/provision.py#L202
##########
table/arrow_utils.go:
##########
@@ -589,9 +592,9 @@ func SchemaToArrowSchema(sc *iceberg.Schema, metadata
map[string]string, include
// TypeToArrowType converts a given iceberg type, into the equivalent Arrow
data type.
// For dealing with nested fields (List, Struct, Map) if includeFieldIDs is
true, then
// the child fields will contain a metadata key PARQUET:field_id set to the
field id.
-func TypeToArrowType(t iceberg.Type, includeFieldIDs bool) (arrow.DataType,
error) {
+func TypeToArrowType(t iceberg.Type, includeFieldIDs bool, useLargeTypes bool)
(arrow.DataType, error) {
Review Comment:
nit add `useLargeTypes` to docstring above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
