nastra commented on code in PR #12391:
URL: https://github.com/apache/iceberg/pull/12391#discussion_r1967496877


##########
build.gradle:
##########
@@ -198,8 +198,10 @@ subprojects {
   dependencies {
     implementation libs.slf4j.api
 
+    testImplementation platform(libs.junit.bom)

Review Comment:
   let's leave introducing the BOM out for now. We can do that in a separate 
PR, where we'd also clean up how dependencies are defined for JUnit (e.g. 
similar to 
https://github.com/apache/iceberg/blob/d6d97d1683465c08d3903673ca6ccbca2004f735/build.gradle#L460-L471).
 Are you interested in introducing the BOM in a separate PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to