pvary commented on code in PR #12366:
URL: https://github.com/apache/iceberg/pull/12366#discussion_r1967212325
##########
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##########
@@ -206,7 +252,7 @@ public EqualityDeleteWriter<Record> newEqDeleteWriter(
@Override
public PositionDeleteWriter<Record> newPosDeleteWriter(
EncryptedOutputFile file, FileFormat format, StructLike partition) {
- MetricsConfig metricsConfig = MetricsConfig.fromProperties(config);
+ MetricsConfig metricsConfig = applyMetricsConfig(() ->
MetricsConfig.forPositionDelete(table));
Review Comment:
Could this work instead of an extra method?
```
MetricsConfig metricsConfig = table != null ?
MetricsConfig.forPositionDelete(table): MetricsConfig.fromProperties(config);
```
For me, this is way easier to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
