mwullink opened a new issue, #12373:
URL: https://github.com/apache/iceberg/issues/12373

   ### Apache Iceberg version
   
   1.8.0 (latest release)
   
   ### Query engine
   
   None
   
   ### Please describe the bug 🐞
   
   Version 1.8.0 removes the trailing slash "/" for every URL.
   This has a negative side effect when using Authentik for oauth2 
authentication.
   
   the Authentic token url is for example : 
https://authentik.domain.tld/application/o/token/
   and is changed to: https://authentik.domain.tld/application/o/token
   
   without the trailing slash, Authentication will return a http 405 
   
   why is Iceberg removing trailing slash? this may also break rother stuff?
   and maybe if not required, then revert this change and keep the url as-is
   
   code is in class  org.apache.iceberg.rest.HTTPRequest and the problem is 
with the "RESTUtil.stripTrailingSlash(fullPath)" part.
   
   ```
     @Value.Lazy
     default URI requestUri() {
       // if full path is provided, use the input path as path
       String fullPath =
           (path().startsWith("https://";) || path().startsWith("http://";))
               ? path()
               : String.format("%s/%s", baseUri(), path());
       try {
         URIBuilder builder = new 
URIBuilder(RESTUtil.stripTrailingSlash(fullPath));
         queryParameters().forEach(builder::addParameter);
         return builder.build();
       } catch (URISyntaxException e) {
         throw new RESTException(
             "Failed to create request URI from base %s, params %s", fullPath, 
queryParameters());
       }
     }
   ```
   
   
   
   
   
   
   ### Willingness to contribute
   
   - [ ] I can contribute a fix for this bug independently
   - [ ] I would be willing to contribute a fix for this bug with guidance from 
the Iceberg community
   - [ ] I cannot contribute a fix for this bug at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to