kevinjqliu commented on code in PR #1699:
URL: https://github.com/apache/iceberg-python/pull/1699#discussion_r1965783990
##########
pyiceberg/table/__init__.py:
##########
@@ -579,7 +579,9 @@ def overwrite(
self.table_metadata.schema(), provided_schema=df.schema,
downcast_ns_timestamp_to_us=downcast_ns_timestamp_to_us
)
- self.delete(delete_filter=overwrite_filter,
case_sensitive=case_sensitive, snapshot_properties=snapshot_properties)
+ if overwrite_filter != AlwaysFalse():
+ # Only delete when the filter is != AlwaysFalse
+ self.delete(delete_filter=overwrite_filter,
case_sensitive=case_sensitive, snapshot_properties=snapshot_properties)
Review Comment:
i thought `self.delete` is a no-op when the `overwrite_filter` is
`AlwaysFalse`, but i like that its more explicit here 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
