nastra commented on code in PR #12369:
URL: https://github.com/apache/iceberg/pull/12369#discussion_r1965380101
##########
core/src/main/java/org/apache/iceberg/deletes/BaseDVFileWriter.java:
##########
@@ -143,7 +143,7 @@ private void write(PuffinWriter writer, Deletes deletes) {
private PuffinWriter newWriter() {
EncryptedOutputFile outputFile = fileFactory.newOutputFile();
- String ident = "Iceberg " + IcebergBuild.fullVersion();
+ String ident = IcebergBuild.fullVersion();
Review Comment:
nit: you might want to just inline it: `return
Puffin.write(outputFile).createdBy(IcebergBuild.fullVersion()).build();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
