Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1963799804
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##########
@@ -106,6 +107,13 @@ public static void startSpark() {
TestCompressionSettings.spark =
SparkSession.builder().master("local[2]").getOrCreate();
}
+ @Before
+ public void resetSpecificConfigurations() {
+ spark.conf().unset(COMPRESSION_CODEC);
+ spark.conf().unset(COMPRESSION_LEVEL);
+ spark.conf().unset(COMPRESSION_STRATEGY);
+ }
Review Comment:
`spark.sql.iceberg.compression-level = 1` is not a valid compression level
setting for gzip. If we don't unset all these options before running each test,
the old configs set by the previous run will be left over and make gzip tests
fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
