bharos commented on code in PR #12327: URL: https://github.com/apache/iceberg/pull/12327#discussion_r1962464380
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ########## @@ -607,6 +607,44 @@ public void addFilteredPartitionsToPartitionedWithNullValueFilteringOnDept() { sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName)); } + @TestTemplate + public void addFileTableOldSpecDataAfterPartitionSpecEvolved() { + createPartitionedFileTable("parquet"); + createIcebergTable( + "id Integer, name String, dept String, subdept String", + "PARTITIONED BY (id, dept, subdept)"); + sql("ALTER TABLE %s DROP PARTITION FIELD dept", tableName); + sql( + "ALTER TABLE %s DROP PARTITION FIELD subdept", + tableName); // This spec is matching with the input data which is partitioned just by "id" + sql("ALTER TABLE %s ADD PARTITION FIELD subdept", tableName); + + if (formatVersion == 1) { + assertThatThrownBy( + () -> + scalarSql( + "CALL %s.system.add_files('%s', '`parquet`.`%s`')", Review Comment: Note that this example drops and adds partition fields which creates void transforms in V1, so checking that case separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org