pvary commented on code in PR #12315:
URL: https://github.com/apache/iceberg/pull/12315#discussion_r1961735029
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -88,6 +88,12 @@ private static String dataLocation(Map<String, String>
properties, String tableL
dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
if (dataLocation == null) {
dataLocation = String.format("%s/data", tableLocation);
+ } else {
+ throw new UnsupportedOperationException(
+ String.format(
+ "Property '%s' has been deprecated and will be removed in
2.0, use '%s' instead.",
+ TableProperties.WRITE_FOLDER_STORAGE_LOCATION,
+ TableProperties.WRITE_DATA_LOCATION));
Review Comment:
Instead of scattering these exceptions around the code, could we add a new
`DEPRECATED_PROPERTIES` set like the currently existing `RESERVED_PROPERTIES`?
We could throw an exception if the property from this list is written, or
read.
This way we can establish a single place where the properties are deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
